From 6bb66be2af4032724024a6ce5165069adc29170a Mon Sep 17 00:00:00 2001
From: mutoe <mutoe@foxmail.com>
Date: Sat, 24 Apr 2021 18:26:47 +0800
Subject: [PATCH] refactor: fix lint issues

---
 .eslintrc                                    |  1 +
 src/components/AppNavigation.vue             |  2 +-
 src/components/ArticleDetailComment.vue      |  7 +++++--
 src/components/ArticleDetailComments.spec.ts |  3 ---
 src/components/PopularTags.spec.ts           |  1 -
 src/pages/Login.vue                          |  3 ++-
 src/pages/Register.vue                       |  3 ++-
 src/pages/Settings.vue                       | 11 ++++++-----
 tsconfig.json                                |  3 ++-
 9 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index ac86226..71bb4e9 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -16,6 +16,7 @@
   "rules": {
     "no-undef": "off",
     "no-unused-vars": "off",
+    "no-labels": "off",
     "comma-dangle": ["warn", "always-multiline"],
     "@typescript-eslint/promise-function-async": "off",
     "@typescript-eslint/strict-boolean-expressions": "off",
diff --git a/src/components/AppNavigation.vue b/src/components/AppNavigation.vue
index dea492a..0dbddc4 100644
--- a/src/components/AppNavigation.vue
+++ b/src/components/AppNavigation.vue
@@ -34,7 +34,7 @@
 <script lang="ts" setup>
 import type { AppRouteNames } from 'src/router'
 import { user } from 'src/store/user'
-import { computed, defineComponent } from 'vue'
+import { computed } from 'vue'
 import type { RouteParams } from 'vue-router'
 
 interface NavLink {
diff --git a/src/components/ArticleDetailComment.vue b/src/components/ArticleDetailComment.vue
index 0d44ee2..48fcff6 100644
--- a/src/components/ArticleDetailComment.vue
+++ b/src/components/ArticleDetailComment.vue
@@ -36,7 +36,7 @@
           role="button"
           aria-label="Delete comment"
           class="ion-trash-a"
-          @click="$emit('remove-comment')"
+          @click="emit('remove-comment')"
         />
       </span>
     </div>
@@ -51,7 +51,10 @@ const props = defineProps<{
   username?: string
 }>()
 
-const emit = defineEmit<(e: 'remove-comment') => boolean>()
+interface Emit {
+  (e: 'remove-comment'): boolean
+}
+const emit = defineEmit<Emit>()
 
 const showRemove = computed(() => (
   props.username !== undefined && props.username === props.comment.author.username
diff --git a/src/components/ArticleDetailComments.spec.ts b/src/components/ArticleDetailComments.spec.ts
index c2c6825..4116499 100644
--- a/src/components/ArticleDetailComments.spec.ts
+++ b/src/components/ArticleDetailComments.spec.ts
@@ -1,13 +1,10 @@
 import { render, waitFor } from '@testing-library/vue'
-import ArticleDetailComment from 'src/components/ArticleDetailComment.vue'
-import ArticleDetailCommentsForm from 'src/components/ArticleDetailCommentsForm.vue'
 import registerGlobalComponents from 'src/plugins/global-components'
 import { router } from 'src/router'
 import { getCommentsByArticle } from 'src/services/comment/getComments'
 import { deleteComment } from 'src/services/comment/postComment'
 import asyncComponentWrapper from 'src/utils/test/async-component-wrapper'
 import fixtures from 'src/utils/test/fixtures'
-import { nextTick } from 'vue'
 import ArticleDetailComments from './ArticleDetailComments.vue'
 
 jest.mock('src/services/comment/getComments')
diff --git a/src/components/PopularTags.spec.ts b/src/components/PopularTags.spec.ts
index 914b2d3..78784cb 100644
--- a/src/components/PopularTags.spec.ts
+++ b/src/components/PopularTags.spec.ts
@@ -3,7 +3,6 @@ import PopularTags from 'src/components/PopularTags.vue'
 import { useTags } from 'src/composable/useTags'
 import registerGlobalComponents from 'src/plugins/global-components'
 import { router } from 'src/router'
-import asyncComponentWrapper from 'src/utils/test/async-component-wrapper'
 import { ref } from 'vue'
 
 jest.mock('src/composable/useTags')
diff --git a/src/pages/Login.vue b/src/pages/Login.vue
index 5964e6e..4553380 100644
--- a/src/pages/Login.vue
+++ b/src/pages/Login.vue
@@ -62,7 +62,8 @@
 
 <script lang="ts" setup>
 import { routerPush } from 'src/router'
-import { postLogin, PostLoginErrors, PostLoginForm } from 'src/services/auth/postLogin'
+import { postLogin } from 'src/services/auth/postLogin'
+import type { PostLoginErrors, PostLoginForm } from 'src/services/auth/postLogin'
 import { updateUser } from 'src/store/user'
 import { reactive, ref } from 'vue'
 
diff --git a/src/pages/Register.vue b/src/pages/Register.vue
index 04c1d92..60b98da 100644
--- a/src/pages/Register.vue
+++ b/src/pages/Register.vue
@@ -69,7 +69,8 @@
 
 <script lang="ts" setup>
 import { routerPush } from 'src/router'
-import { postRegister, PostRegisterErrors, PostRegisterForm } from 'src/services/auth/postRegister'
+import { postRegister } from 'src/services/auth/postRegister'
+import type { PostRegisterErrors, PostRegisterForm } from 'src/services/auth/postRegister'
 import { updateUser } from 'src/store/user'
 import { reactive, ref } from 'vue'
 
diff --git a/src/pages/Settings.vue b/src/pages/Settings.vue
index 72f9c27..7f41a8d 100644
--- a/src/pages/Settings.vue
+++ b/src/pages/Settings.vue
@@ -75,7 +75,8 @@
 
 <script lang="ts" setup>
 import { routerPush } from 'src/router'
-import { putProfile, PutProfileForm } from 'src/services/profile/putProfile'
+import { putProfile } from 'src/services/profile/putProfile'
+import type { PutProfileForm } from 'src/services/profile/putProfile'
 import { checkAuthorization, updateUser, user } from 'src/store/user'
 import { computed, onMounted, reactive } from 'vue'
 
@@ -104,9 +105,9 @@ onMounted(async () => {
 
 const isButtonDisabled = computed(() => (
   form.image === user.value?.image &&
-      form.username === user.value?.username &&
-      form.bio === user.value?.bio &&
-      form.email === user.value?.email &&
-      !form.password
+  form.username === user.value?.username &&
+  form.bio === user.value?.bio &&
+  form.email === user.value?.email &&
+  !form.password
 ))
 </script>
diff --git a/tsconfig.json b/tsconfig.json
index 9203fcb..08714d0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -11,7 +11,8 @@
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
   },
   "include": [
     "src"